Skip to content

fix(deps): update DA dependencies + example / tests cleanup #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 19, 2025
Merged

fix(deps): update DA dependencies + example / tests cleanup #106

merged 3 commits into from
Sep 19, 2025

Conversation

@ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented Sep 18, 2025 •
edited
Loading

Description

  • Update dependant DAs to latest versions
  • Made the basic example more basic (use COS instead of Event Streams)
  • Set CheckApplyResultForUpgrade: true for upgrade test to ensure apply is done on upgrade
  • Set up DA tests to use same tf version that DA is locked in to

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh ocofaigh mentioned this pull request Sep 18, 2025
Merged
6 tasks
iamar7
iamar7 requested changes Sep 19, 2025
View reviewed changes
examples/basic/README.md Outdated
- A new standard plan Cloud Object Storage instance using the root level module.
- A new COS instance and bucket.
- An Activity Tracker target for the new COS bucket.
- And Activity Tracker route for the COS bucket target.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- And Activity Tracker route for the COS bucket target.
- An Activity Tracker route for the COS bucket target.

@ocofaigh ocofaigh mentioned this pull request Sep 19, 2025
Merged
6 tasks
@ocofaigh ocofaigh marked this pull request as ready for review September 19, 2025 10:19
@ocofaigh ocofaigh requested a review from vkuma17 as a code owner September 19, 2025 10:19
@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

Hit a Schematics issue: There was an internal error. The state file may be partially updated. Please verify resources and try after some time. Action recovered by orchestrator-6b8f4678bc-w9l8k

Reported internally. Re-running..

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author 

    tests.go:540: =============== BEGIN APPLY JOB LOG (eu-de.workspace.at-fc-upg-j7h.a4fd8293) ===============
        SCHEMATICS LOG URL: https://cloud.ibm.com/schematics/workspaces/eu-de.workspace.at-fc-upg-j7h.a4fd8293/log/cfd61214c0687a4a79b1826a9f3ddc63
         2025/09/19 11:07:49 -----  New Workspace Action  -----
         2025/09/19 11:07:49 Request: activitId=cfd61214c0687a4a79b1826a9f3ddc63, account=abac0df06b644a9cabc6e44f55b3880e, [email protected], requestID=4618c296-c369-4f2b-b971-6cdc7bab4ced
         2025/09/19 11:07:50 Related Activity: action=APPLY, workspaceID=eu-de.workspace.at-fc-upg-j7h.a4fd8293, processedBy=orchestrator-7d56bc5847-hllgv
         2025/09/19 11:07:50 Related Workspace: name=at-fc-upg-j7h, sourcerelease=(not specified), sourceurl=, folder=solutions/fully-configurable
         2025/09/19 11:07:53  --- Ready to execute the command --- 
         2025/09/19 11:07:58  --- Ready to execute the command --- 
         2025/09/19 11:08:05  --- Ready to execute the command --- 
         2025/09/19 11:08:11  --- Ready to execute the command --- 
         2025/09/19 11:08:14 Could not persist Activity with status INPROGRESS
         2025/09/19 11:08:14 workspace.template.EnvFile: 5b67f7ad-5206-4125-9ac8-07ea90333e9e
         2025/09/19 11:08:16 workspace.template.SecFile: 18683988-27c3-4913-bfa2-309dbcf4701e
         2025/09/19 11:08:16 Invalid or expired refresh token
         2025/09/19 11:08:16 There was an internal Error. Please verify the resources and retry after some time.
         2025/09/19 11:08:30 *** There was an internal error. The state file may be partially updated. Please verify resources and try after some time. Action recovered by orchestrator-7d56bc5847-x8xg4 ***

retrying..

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit b155c0c into main Sep 19, 2025
2 checks passed
@ocofaigh ocofaigh deleted the tests branch September 19, 2025 12:13
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.2.34 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamar7 iamar7 iamar7 approved these changes

@vkuma17 vkuma17 Awaiting requested review from vkuma17

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ocofaigh @terraform-ibm-modules-ops @iamar7